Skip to content

Conversation

@link2xt
Copy link
Contributor

@link2xt link2xt commented Oct 31, 2025

acmetool is always running in redirector mode and has a hook that restarts or reload services, there is no need to do the same manually.

@link2xt link2xt mentioned this pull request Oct 31, 2025
@link2xt
Copy link
Contributor Author

link2xt commented Oct 31, 2025

This was added in 9c09d50 when hook was already in place.

@missytake
Copy link
Contributor

This was added in 9c09d50 when hook was already in place.

It was added because the hook didn't work :( in any case, it would be much nicer to have a systemd timer executing this. Then we can investigate when a cert job fails, and see whether it actually ran. I suggest to do this instead?

@link2xt
Copy link
Contributor Author

link2xt commented Nov 6, 2025

It was added because the hook didn't work :( in any case, it would be much nicer to have a systemd timer executing this. Then we can investigate when a cert job fails, and see whether it actually ran. I suggest to do this instead?

The hook is there, if it does not work then it should have been fixed instead. Why do we hack our own solution with cron or timers when acmetool is supposed to be doing this?

I see the hook is installed in /usr/lib/acme/hooks/nginx, but the man page says it should go to /etc/acme/hooks.

@link2xt link2xt closed this Nov 6, 2025
@link2xt
Copy link
Contributor Author

link2xt commented Nov 6, 2025

It seems acmetool-redirector is not renewing certificates, so we need a timer.
I opened #719 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants